Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for oauth2 with preregistered token #955

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

rampaq
Copy link
Contributor

@rampaq rampaq commented Jul 26, 2023

Issue #954 for OAUTH2 support.

@hchasens
Copy link

Making cyrus-sasl-xoauth2-git a dependency might be an issue. If you're not on Arch than you don't have access to the AUR. Without it, installing cyrus-sasl-xoauth2-git requires building it from source. It's documentation doesn't list which dependencies it needs which makes the process even more difficult. I think OAUTH2 is important. Maybe if it's packaged outside of the AUR?

@rampaq
Copy link
Contributor Author

rampaq commented Jul 30, 2023

I think there might be other alternatives providing sasl-xoauth2 as suggested by Arch Wiki but I haven't found any: https://wiki.archlinux.org/title/isync#Using_XOAUTH2

@rampaq
Copy link
Contributor Author

rampaq commented Jul 30, 2023

Also, I haven't tested the code very throughougly as I have a quite custom mutt setup conflicting with auto-management by mutt-wizard.

@hchasens
Copy link

hchasens commented Oct 8, 2023

I definitely think OAuth is worth pursuing. I tested your fork on Fedora. Due to the difficulties setting up the dependencies, I found it much easier to just manually configure OAuth without the wizard. If we can figure out the dependency issue though, this'll add a good layer of security and usability.

@rampaq
Copy link
Contributor Author

rampaq commented Oct 9, 2023

Thanks for testing! What do you mean by

I found it much easier to just manually configure OAuth without the wizard.

Do you mean that you needed debugging messages during the setup process from to pinpoint problems with the dependencies?

@rampaq
Copy link
Contributor Author

rampaq commented Oct 9, 2023

I have missed a mbsync config for OAUTH support. That is fixed now and conflicts with master branch resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants